<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111829/">http://git.reviewboard.kde.org/r/111829/</a>
</td>
</tr>
</table>
<br />
<p>On August 15th, 2013, 10:50 p.m. UTC, <b>Eugene Shalygin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the review! I've tried to fix the issues. The only one left is question with Generator::DPI. I've replaced it with QSizeF (not the best choice, I know). Somehow keeping both X and Y dpis together makes me happy :)
Is it good to keep it as is, or replace with a pair of qreals?</pre>
</blockquote>
<p>On August 15th, 2013, 11 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems our comments crossed themselves in the internet, I don't actually like QSize since it's not a size, I am not sure i like DPI because it's a new class just two store two numbers, but i don't have a strong opinion. If you really want to keep them together, bring the DPI class, but please make the implementation private (i.e. not all over the header)</pre>
</blockquote>
<p>On August 15th, 2013, 11:21 p.m. UTC, <b>Eugene Shalygin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would not use two qreals not only because of esthetical reason (keeping two related values together is certainly good), but there is also at least one practical at the moment: we can have only one function realDpi() instead of two.
Therefore, I would use a DPI class even in the Utils class. But if you say that that would complicate support, we can live with qreals.
But, since DPI class is just two numbers, without functions, and I can not see how its structure can change in the future, I would think that inline class is fine (comparing to private implementation, i.e. exported symbols).</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, bring back the DPI class back, don't put it in generator though, makes not much sense there, maybe utils.h or somewhere like that. Also don't really like the DPI name much, maybe DPIValues? DPISettings? (that one is probably bad too).
</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 15th, 2013, 10:46 p.m. UTC, Eugene Shalygin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2013, 10:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch relies on master branch of LibKScreen.
This patch does not solve the problem in bug completely, but makes Okular behaviour more correct (see below).
The problem (in the bug) is that Okular uses fixed DPI for PDF rendering (72.0 dots per inch) and therefore scale of rendered document becomes incorrect. With current mainline laptop screens having DPI easily twice larger than this constant (72), the problem shows itself quiet strongly.
Additional problems araise with multiscreen configuration, when 1) DPI of each individual screen may be different, and 2) there is no tools in Qt to detect DPI of individual screens in virtual desktop mode. Therefore XRandr has to be used for DPI detection. Raw XRandr is bad dependency for Okular and libkscreen is proposed instead.
This patch approach to the solution in the following way:
1. libkscreen detection staff is added to CMakeLists.txt and config.h
2. It changes Utils::realDpi() function to use libkscreen if present. With libkscreen the function looks for output that contains maximal part of given widget (suppose to be used for document rendering) and returns DPI of that screen.
3. Genenerator interface is extended by adding UtilizeDPI feature and setDPI() method, that is called by Document class right before calling loadXXX() if the generator supports this feature
4. Poppler generator is changed to support UtilizeDPI feature.
5. PageSizeMetric enum is extended with Pixels value to explicitly say that page size is defined in screen pixels (see my posts in the bug); Poppler generator uses this case.
To completetly fix the bug, Document must invalidate generated pixmaps after the widget movements into another screen. I do not know how to track this without subclassing the main window class. Therefore I decided to publish this part of work to get your responce, especially regarding item 3 (Generator class changes).
In the current state, manual reloading of a document after moving Okular to another screen fixes the scale, that is, in my eyes, is quiet helpful already.
Even if we subclass the Okular main window, I do not know what to do when Okular is used as KPart.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual. In all screens, that report correct physical size to XRandr, size of documents is correct</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268757">268757</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/utils.cpp <span style="color: grey">(5dd8448)</span></li>
<li>core/generator_p.h <span style="color: grey">(b59293a)</span></li>
<li>core/utils.h <span style="color: grey">(8d5d5fc)</span></li>
<li>core/generator.cpp <span style="color: grey">(41beb92)</span></li>
<li>core/document_p.h <span style="color: grey">(3a257de)</span></li>
<li>core/generator.h <span style="color: grey">(a5a971b)</span></li>
<li>core/document.cpp <span style="color: grey">(3af92c8)</span></li>
<li>CMakeLists.txt <span style="color: grey">(217337f)</span></li>
<li>config-okular.h.cmake <span style="color: grey">(7217f8d)</span></li>
<li>generators/poppler/generator_pdf.h <span style="color: grey">(5d5853a)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(1a44523)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111829/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>