<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111782/">http://git.reviewboard.kde.org/r/111782/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest I can't see why it would have a binding loop after looking at the code
If you think it works, please commit it. To which branch i don't know, 4.11 i guess?</pre>
<br />
<p>- Albert</p>
<br />
<p>On July 29th, 2013, 6:48 p.m. UTC, Fabio D'Urso wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 6:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Marco Martin discovered, at some zoom levels on my laptop okular active tries to draw page pixmaps at non-exact pixel boundaries, resulting in almost unreadable text (see attached video).
This patch fixes the issue by rounding the page position to the nearest pixel. Unfortunately, this patch also seems introduce a binding loop:
QML PageItem_QML_18: Binding loop detected for property "x"
I'm creating this review request as remainder for further investigation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/app/package/contents/ui/FullScreenDelegate.qml <span style="color: grey">(ac308aa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111782/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/screen-recording.ogv">Screen recording of the issue</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>