<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111554/">http://git.reviewboard.kde.org/r/111554/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 18th, 2013, 2:31 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111554/diff/1/?file=171295#file171295line220" style="color: black; font-weight: bold; text-decoration: underline;">generators/epub/converter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QTextDocument* Converter::convert( const QString &fileName )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">220</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span><span class="n">ht</span> <span class="o">></span> <span class="mi">718</span><span class="p">)</span> <span class="n">ht</span> <span class="o">=</span> <span class="mi">718</span><span class="p">;</span> <span class="c1">// 718 because there has to be some space for the page delimiter else there'll be a new blank page after this</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where does this 718/560 come from?</pre>
</blockquote>
<p>On July 19th, 2013, 7:26 a.m. UTC, <b>Jaydeep Solanki</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Width of a page is 600, and as we are having a padding of 20px around a page, it gives 560(600 - 20[left] - 20[right]).
Similarly in the case of height, we have a page of size 800 leaving the padding we get 760.
A page break is inserted after a page delimiter(PD) is encountered. A PD also takes up some space, so if we just count the paddings & the size of the content then including the PD will exceed a page's size & the second page will contain PD + page break, which makes it a blank page.
So, to fit all that in a single page, I made it 718 (800 - 20[top] - 20[bottom] - height of PD).
I found the height of PD, with some trial & error.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it'd be cool if we could have some static conts int around for those values.
Also, can you check where that PD value comes from? Maybe it depends on the style you are using and thus we should query it using QStyle?</pre>
<br />
<p>- Albert</p>
<br />
<p>On July 17th, 2013, 8:13 p.m. UTC, Jaydeep Solanki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jaydeep Solanki.</div>
<p style="color: grey;"><i>Updated July 17, 2013, 8:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Epubs use the below syntax to load svg images
<svg>
<image width="592" height="900" xlink:href="images/cover.svg" />
</svg>
I just replace that with <img> tags & add QImage as a resource.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The below link contains two epub files having svg images as cover.
https://www.dropbox.com/sh/xcqfwn8khbqac0d/vDRuFRw9vq</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/epub/epubdocument.h <span style="color: grey">(714ede6)</span></li>
<li>generators/epub/converter.cpp <span style="color: grey">(74df151)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(9442f61)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>