<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110480/">http://git.reviewboard.kde.org/r/110480/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, thank you for noticing, however this patch looks wrong to me: it's assigning txtann's contents variable to itself.
I remember why I added this special case, because Poppler < 0.20 sometimes stored garbage in the DOM node corresponding to inplaceText (but good data in contents).
This code copied the good value into inplaceText, so that Okular's UI code, which used to show the user what it read from inplaceText, showed the good value instead.
Now that Okular only has contents, this special handling is no longer needed, therefore that block can be removed at all. I'm fixing it myself.
Thank you again for testing poppler 0.18, which I had forgotten to check when I reviewed the other patch :)</pre>
<br />
<p>- Fabio</p>
<br />
<p>On May 17th, 2013, 12:13 a.m. UTC, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated May 17, 2013, 12:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems than poppler used it.
And compilation error occurs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiling is ok</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/poppler/annots.cpp <span style="color: grey">(3694188)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110480/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>