<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109021/">http://git.reviewboard.kde.org/r/109021/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 13th, 2013, 10:48 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109021/diff/3/?file=142972#file142972line217" style="color: black; font-weight: bold; text-decoration: underline;">core/textdocumentgenerator.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class OKULAR_EXPORT TextDocumentGenerator : public Generator</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class OKULAR_EXPORT TextDocumentGenerator : public Generator, public Okular::ConfigInterface</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">217</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">initializeGenerator</span><span class="p">(</span> <span class="n">TextDocumentConverter</span> <span class="o">*</span><span class="n">converter</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should ideally be a function of the private class</pre>
</blockquote>
<p>On May 13th, 2013, 11:27 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you explain why you think so?</pre>
</blockquote>
<p>On May 13th, 2013, 11:39 p.m. UTC, <b>Fabio D'Urso</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't followed the discussion, but I think I can answer.
Because Okular tries to expose as little as possible to external modules, in order to minimize chances of ABI breakage (the compiler doesn't know that initializeGenerator exists so it can't bind your code on it).</pre>
</blockquote>
<p>On May 13th, 2013, 11:44 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure I can do this, but as far as I know, ABI won't be broken, because here I just add new method, like a new constructor.</pre>
</blockquote>
<p>On May 14th, 2013, 5:42 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually think about it the other way around. Is there any need for it to be in the public class? If not, shouldn't be there.</pre>
</blockquote>
<p>On May 16th, 2013, 8:39 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We have one unresolved issue.
I don't wanted to inheriting private class from QObject, do you think it really need to do?
Also I suggest to move this into another patch.</pre>
</blockquote>
<p>On May 16th, 2013, 9:17 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why you need the private class to inherit from QObject to make void initializeGenerator( TextDocumentConverter *converter ); private?</pre>
</blockquote>
<p>On May 16th, 2013, 9:18 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Err, i mean to move void initializeGenerator( TextDocumentConverter *converter ); to the private class, sorry :D</pre>
</blockquote>
<p>On May 16th, 2013, 9:40 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because it has some slots, example addAction:
Q_PRIVATE_SLOT( d_func(), void addAction( Action*, int, int ) )
And I don't want to call this using Q_Q(), because this add more relation between private/public classes.
Even if we do this (drop Q_PRIVATE_SLOT(), and add private slots into private class, and inherit it from QObject),
we still have more methods/slots/signals from public class that we must use from private:
setFeature()
SIGNAL(error())
e.t.c.
If you ok with that, I have to change it.</pre>
</blockquote>
<p>On May 16th, 2013, 10:01 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think I'm not explaining myself correctly. No worries, i'll do that part myself :-)</pre>
</blockquote>
<p>On May 16th, 2013, 10:03 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems that I misunderstood you, I will look into final patches in repository for the right explanation.
Thanks.</pre>
</blockquote>
<p>On May 16th, 2013, 10:15 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, here's what i meant.
http://paste.kde.org/~tsdgeos/745328/
Clearer now?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, thanks. I did the same in the last patch.</pre>
<br />
<p>- Azat</p>
<br />
<p>On May 16th, 2013, 10:02 p.m. UTC, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular, Albert Astals Cid and Eike Hein.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated May 16, 2013, 10:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Development history:
https://github.com/azat/okular/compare/master...font-selector-for-plain-text-formats
http://quickgit.kde.org/?p=clones%2Fokular%2Fazatkhuzhin%2Fokular.git&a=commitdiff&h=font-selector-for-plain-text-formats&hp=master
(but it has some delay, about a day or so while this clone will be updated, maybe because of mirrors?)
Link to thread from mailing list:
http://comments.gmane.org/gmane.comp.kde.devel.okular/13279</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested manually</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(543e6df)</span></li>
<li>conf/textdocumentsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/textdocumentgenerator.h <span style="color: grey">(dd75c5c)</span></li>
<li>core/textdocumentgenerator.cpp <span style="color: grey">(f370ded)</span></li>
<li>core/textdocumentgenerator_p.h <span style="color: grey">(749d6f2)</span></li>
<li>core/textdocumentsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/textdocumentsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/textdocumentsettings_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(f076ed9)</span></li>
<li>generators/epub/generator_epub.h <span style="color: grey">(cef2879)</span></li>
<li>generators/epub/generator_epub.cpp <span style="color: grey">(59bb2bf)</span></li>
<li>generators/epub/libokularGenerator_epub.desktop <span style="color: grey">(5c853a3)</span></li>
<li>generators/fictionbook/generator_fb.h <span style="color: grey">(a898397)</span></li>
<li>generators/fictionbook/generator_fb.cpp <span style="color: grey">(2317083)</span></li>
<li>generators/fictionbook/libokularGenerator_fb.desktop <span style="color: grey">(099268c)</span></li>
<li>generators/ooo/converter.cpp <span style="color: grey">(1124e2a)</span></li>
<li>generators/ooo/generator_ooo.h <span style="color: grey">(3441c7a)</span></li>
<li>generators/ooo/generator_ooo.cpp <span style="color: grey">(793ee58)</span></li>
<li>generators/ooo/libokularGenerator_ooo.desktop <span style="color: grey">(328ae26)</span></li>
<li>generators/txt/CMakeLists.txt <span style="color: grey">(5a126b7)</span></li>
<li>generators/txt/generator_txt.h <span style="color: grey">(5c15ec4)</span></li>
<li>generators/txt/generator_txt.cpp <span style="color: grey">(93ca4aa)</span></li>
<li>generators/txt/libokularGenerator_txt.desktop <span style="color: grey">(235e23d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109021/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>