<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110419/">http://git.reviewboard.kde.org/r/110419/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Fabio D'Urso.</div>
<p style="color: grey;"><i>Updated May 13, 2013, 11:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very simple patch that sets default Save As path the same as the path the document has been opened from.
I've used katepart as reference:
https://projects.kde.org/projects/kde/applications/kate/repository/revisions/fbeecb7384e3c3986e8fbafa1123aa422d97e537/entry/part/document/katedocument.cpp#L3832
Note that this patch does *not* affect Save Copy As.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've verified that "Save As" now behaves the same as katepart/kwrite. I've only found a difference in stdin handling.
$ okular, then open local file from Open menu
Defaults to the same path as expected. Obviously same behavior as kwrite.
$ okular, then open remote HTTP file from Open menu
Defaults to the same path, shows a HTTP folder. It's the same behavior as kwrite.
$ okular /path/to/local/file
Defaults to the same path as expected. Obviously same behavior as kwrite.
$ okular http://remote/file
Defaults to local file with the same name. Same behavior as kwrite.
$ cat /path/to/local/file | okular -
Defaults to "-". Note that "kwrite -stdin", instead, shows no default name in this case.
Bookmarks:
I've tested opening bookmarks from local files and it defaulted to the bookmarked path as expected.
Opening HTTP bookmarks didn't work (seems we store a wrong URL, but it's not related to this patch)
okularpart embedded in konqueror:
Defaults to local file with the same name. Same behavior as katepart embedded in konqueror.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319042">319042</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.cpp <span style="color: grey">(eae6a2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110419/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>