<div dir="ltr"><div>Would you like to see my final proposal before I submit ?<br><br></div>Cheers,<br>Jaydeep<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 22, 2013 at 9:27 AM, Jaydeep Solanki <span dir="ltr"><<a href="mailto:jaydp17@gmail.com" target="_blank">jaydp17@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Mon, Apr 22, 2013 at 2:54 AM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">El Dissabte, 20 d'abril de 2013, a les 18:07:20, Jaydeep Solanki va escriure:<br>
<div>> I would go for webkit, because as HTML develops webkit developers will<br>
> improve it where as in QTextDocument case it's not sure that it will come<br>
> up with the latest standards. Or if we try to improve it and maintain it,<br>
> the maintenance load will increase.<br>
> Also I looked at other ePub viewers such as calibre and it too uses webkit.<br>
><br>
> I did some tests and webkit seems to be working out of the box.<br>
<br>
</div>What do you mean with "some tests"?<br></blockquote></div><div>I wrote a small test app, that renders epub using webkit, it works well, as expected.<br></div><div>And for the QTextDocument one I edited Okular source, to see if small tricks like setting the 'whole html' again when any css property for body tag appears, worked? But it was not efficient and as such it was a workaround not the proper way of doing it, which would lead to adding more such workarounds when more bugs of such kind arise.So I finally settled on webkit.<br>
</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><br>
> BTW, I had a doubt, as currently every generator gives a QTextDocument, do<br>
> we have to change all of the generators to make it work with webkit, or<br>
> just the specific ePub one ?<br>
<br>
</div>What do you think?<br></blockquote></div><div>I think it should be only the ePub generator, because if it's otherwise, I guess I have a lot to do this summer :-)<br><br></div><div>I also wanted to ask, if it is fine if I submit my proposal as soon as the student application period starts? which is probably less than 24 hours from now.<br>
<br></div><div>Cheers,<br>Jaydeep<br><br></div><div><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Albert<br>
<div><div><br>
><br>
> Cheers,<br>
> Jaydeep<br>
><br>
> On Fri, Apr 19, 2013 at 2:54 AM, Albert Astals Cid <<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>> wrote:<br>
> > El Dijous, 18 d'abril de 2013, a les 23:49:00, Jaydeep Solanki va<br>
escriure:<br>
> > > Incase my previous mail didn't reach you because of heavy attachment,<br>
> ><br>
> > here<br>
> ><br>
> > > is another one.<br>
> > > Hello,<br>
> > > I would be really happy if you can review the proposal that I have<br>
> ><br>
> > created.<br>
> ><br>
> > > Proposal link : <a href="http://db.tt/7pynIIKN" target="_blank">http://db.tt/7pynIIKN</a><br>
> ><br>
> > Looks correct, one way of improving it would be doing some of the<br>
> > preliminary<br>
> > work to see if you'd prefer to go the QTextDocument or the Wekbit route.<br>
> ><br>
> > Cheers,<br>
> ><br>
> > Albert<br>
> ><br>
> > > Thank you.<br>
> > ><br>
> > > Cheers,<br>
> > > Jaydeep Solanki<br>
> ><br>
> > _______________________________________________<br>
> > Okular-devel mailing list<br>
> > <a href="mailto:Okular-devel@kde.org" target="_blank">Okular-devel@kde.org</a><br>
> > <a href="https://mail.kde.org/mailman/listinfo/okular-devel" target="_blank">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
_______________________________________________<br>
Okular-devel mailing list<br>
<a href="mailto:Okular-devel@kde.org" target="_blank">Okular-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/okular-devel" target="_blank">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
</div></div></blockquote></div></div></div><br></div></div>
</blockquote></div><br></div>