<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109632/">http://git.reviewboard.kde.org/r/109632/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 22nd, 2013, 8:19 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo annotations code gets merged. I'd suggest you have a look at it and try to find out how you'd apply your changes on top of it.</pre>
</blockquote>
<p>On March 23rd, 2013, 9:06 p.m. UTC, <b>Peter Grasch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll hold off until that is committed then. No reason to start complicating things, this is not that urgent.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think it will be difficult to rebase your changes onto the new undo functionality (once it's merged) but let me know if you have any questions.</pre>
<br />
<p>- Jon</p>
<br />
<p>On March 21st, 2013, 1:26 a.m. UTC, Peter Grasch wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Peter Grasch.</div>
<p style="color: grey;"><i>Updated March 21, 2013, 1:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prerequisites: Please read till the end!
This introduces a new annotation tool: "Eraser".
The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.).
However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved.
This is what it looks like: http://bedahr.org/eraser.ogv
Example tool configuration for your tools.xml (not included in patch):
<tool id="15" name="Eraser" pixmap="tool-eraser-okular">
<tooltip>Eraser</tooltip>
<engine type="Eraser" />
<shortcut>7</shortcut>
</tool>
The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change.
I hope we can resume the discussion about possible improvements here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/pageviewannotator.cpp <span style="color: grey">(7bd7496)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109632/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>