<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109364/">http://git.reviewboard.kde.org/r/109364/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 9th, 2013, 4:12 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure this is the totally correct fix (I'm not saying the code we have now is better). But i do have here epubs that set the color of the text to black ( e.g http://bugs.kde.org/attachment.cgi?id=51488 ), so in case my i would get black on black :-/
On the other hand i see the problem the reporter is having.
OTOH in further inspection of http://bugs.kde.org/attachment.cgi?id=51488 seems it is declaring it wants its background to be white, wonder why we are not getting it white then :S
Do yo have time to investigate why this is happening? Because it we commit this patch directly i feel it would be going from one bug to another, and not sure it makes much sense</pre>
</blockquote>
<p>On March 10th, 2013, 4:16 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm working on it, but for now the patch attached here is the simplest way to fix it.
Because user can change color scheme and read document (background will be changed), instead always white background.
But for now, I'm trying to extract background from epub documents, and when I do that, I'll upload the patch.</pre>
</blockquote>
<p>On March 10th, 2013, 4:34 p.m. UTC, <b>Azat Khuzhin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems that we can't extract background color for epub documents (in particular for this one)
There is no information about background colors.
We can force text color to opposite (black -> white), but, in my opinion, this is not correct.
Or we can rewrite epub backend not to use libepub, than, I think, we can get such information.</pre>
</blockquote>
<p>On March 10th, 2013, 11:19 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"user can change color scheme and read document", well they can already do that now, no?
"There is no information about background colors." it's there in the CSS we pass down to QTextDocument, i guess the question is why that's not working.
Do you have time to do a simple code check with something like
body {
background-color:#fff;
}
in the css and see if it works? Because that's close to what we are passing down to QTextDocument.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- well they can already do that now, no?
Sure they do, but, the background always be white, without this patch.
I've already tested this, and background-color property is not presented in output QTextDocument::toHtml()</pre>
<br />
<p>- Azat</p>
<br />
<p>On March 8th, 2013, 11:38 p.m. UTC, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated March 8, 2013, 11:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Instead of just force it to white.
This must fix bug 306572.
https://bugs.kde.org/show_bug.cgi?id=306572</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306572">306572</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/textdocumentgenerator.cpp <span style="color: grey">(f370ded)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109364/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>