<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109119/">http://git.reviewboard.kde.org/r/109119/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 27th, 2013, 10:43 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Code looks, ok, but now the big question, is this really an improvement? I guess the only improvement would be speed-wise and not encoding-detection-wise. Have you opened really big files and noticed it is faster? Otherwise maybe there is no really need to change the existing code if it works as well?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes it is only speed-wise improvement, as I already told.
> Description:
> Don't to extra job, when encoding is detected just return encoding.
For big files there is improvement, but this files is quite big (~900 000 lines long), if we oriented on books
Just two times faster for such number of lines.
Maybe there is no need in this patch, but for me it more appropriate way.</pre>
<br />
<p>- Azat</p>
<br />
<p>On February 25th, 2013, 8:15 p.m. UTC, Azat Khuzhin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Azat Khuzhin.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2013, 8:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Don't to extra job, when encoding is detected just return encoding.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/txt/document.h <span style="color: grey">(08babea)</span></li>
<li>generators/txt/document.cpp <span style="color: grey">(badb647)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109119/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>