<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109115/">http://git.reviewboard.kde.org/r/109115/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109115/diff/2/?file=115089#file115089line200" style="color: black; font-weight: bold; text-decoration: underline;">active/components/documentitem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DocumentItem::resetSearch()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">197</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">m_<span class="hl">o</span>bserver<span class="hl">s</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">contains</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">id</span></span><span class="p"><span class="hl">))</span></span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">200</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">m_<span class="hl">thumbnailO</span>bserver</span><span class="p"><span class="hl">)</span></span><span class="hl"><span class="ew"> </span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove trailing space</pre>
</div>
<br />
<p>- Bogdan</p>
<br />
<p>On February 23rd, 2013, 6:27 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2013, 6:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make observer.h installable
To make sense in doing that kill the harcoded observer ids, move the priorities to an okular-ui only place and make the pixmap preload easier to access (not depend on random priority values)
We need the m_tiledObserver hack since we only support one tiled observer in the code.
Also kill viewId from View since doesn't make sense either and is unused :-)
Note, there are twohtml pages in the "view diff" page
Marco, Aaron, I haven't tried the active part, could you give it a quick try?
Superceeds https://git.reviewboard.kde.org/r/107047/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, after some tests doesn't seem to crash.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/toc.cpp <span style="color: grey">(bde7c97)</span></li>
<li>ui/pagesizelabel.h <span style="color: grey">(7c4a1e2)</span></li>
<li>ui/pageview.h <span style="color: grey">(d8a7653)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(60a273d)</span></li>
<li>ui/presentationwidget.h <span style="color: grey">(1608ef8)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(35b9d34)</span></li>
<li>ui/priorities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/side_reviews.h <span style="color: grey">(bbd8324)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(a35f9ed)</span></li>
<li>ui/thumbnaillist.h <span style="color: grey">(20c434f)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(f191274)</span></li>
<li>ui/toc.h <span style="color: grey">(8679648)</span></li>
<li>core/rotationjob.cpp <span style="color: grey">(e26bd6b)</span></li>
<li>core/rotationjob_p.h <span style="color: grey">(305e2a1)</span></li>
<li>core/view.h <span style="color: grey">(d1fa376)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(d87071a)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(c342a10)</span></li>
<li>generators/spectre/generator_ghostview.cpp <span style="color: grey">(d687d01)</span></li>
<li>part.h <span style="color: grey">(e3a9418)</span></li>
<li>part.cpp <span style="color: grey">(f1cdc11)</span></li>
<li>ui/annotationmodel.cpp <span style="color: grey">(d6d234d)</span></li>
<li>ui/bookmarklist.h <span style="color: grey">(cb8fcc3)</span></li>
<li>ui/bookmarklist.cpp <span style="color: grey">(e1b3869)</span></li>
<li>ui/minibar.h <span style="color: grey">(185adff)</span></li>
<li>ui/pagepainter.h <span style="color: grey">(42a7313)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(91ae211)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e40cfd6)</span></li>
<li>active/components/documentitem.h <span style="color: grey">(750e5af)</span></li>
<li>active/components/documentitem.cpp <span style="color: grey">(404d863)</span></li>
<li>active/components/pageitem.h <span style="color: grey">(0db4080)</span></li>
<li>active/components/pageitem.cpp <span style="color: grey">(a04a8dc)</span></li>
<li>core/bookmarkmanager.cpp <span style="color: grey">(accd65f)</span></li>
<li>core/document.h <span style="color: grey">(1d825e1)</span></li>
<li>core/document.cpp <span style="color: grey">(372af56)</span></li>
<li>core/document_p.h <span style="color: grey">(57a3bee)</span></li>
<li>core/generator.h <span style="color: grey">(420bd41)</span></li>
<li>core/generator.cpp <span style="color: grey">(402c881)</span></li>
<li>core/generator_p.h <span style="color: grey">(66d4574)</span></li>
<li>core/observer.h <span style="color: grey">(f7189be)</span></li>
<li>core/page.h <span style="color: grey">(6bc60c5)</span></li>
<li>core/page.cpp <span style="color: grey">(4df58e0)</span></li>
<li>core/page_p.h <span style="color: grey">(75575a7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>