<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109115/">http://git.reviewboard.kde.org/r/109115/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 23rd, 2013, 8:25 p.m. UTC, <b>Bogdan Cristea</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It crashes while opening pdf or chm files. Below is the crash report for pdf file
Application: Okular (okular), signal: Segmentation fault
Using host libthread_db library "/lib64/libthread_db.so.1".
[KCrash Handler]
#5 Okular::DocumentPrivate::searchLowestPriorityPixmap (this=this@entry=0x14abf90, unloadableOnly=unloadableOnly@entry=true, thenRemoveIt=thenRemoveIt@entry=false, observer=observer@entry=0x0) at /home/bogdan/Build/okular/core/document.cpp:426
#6 0x00007f0550afeac9 in Okular::DocumentPrivate::sendGeneratorPixmapRequest (this=this@entry=0x14abf90) at /home/bogdan/Build/okular/core/document.cpp:1140
#7 0x00007f0550aff5d7 in Okular::DocumentPrivate::requestDone (this=0x14abf90, req=0x18cf6c0) at /home/bogdan/Build/okular/core/document.cpp:4182
#8 0x00007f0550b117b6 in Okular::GeneratorPrivate::pixmapGenerationFinished (this=0x1865540) at /home/bogdan/Build/okular/core/generator.cpp:108
#9 0x00007f055d3e70ae in QObject::event(QEvent*) () from /usr/lib64/libQtCore.so.4
#10 0x00007f055e02974c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#11 0x00007f055e02dc7a in QApplication::notify(QObject*, QEvent*) () from /usr/lib64/libQtGui.so.4
#12 0x00007f055ed3d006 in KApplication::notify(QObject*, QEvent*) () from /usr/lib64/libkdeui.so.5
#13 0x00007f055d3d273e in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib64/libQtCore.so.4
#14 0x00007f055d3d6091 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/lib64/libQtCore.so.4
#15 0x00007f055d4007a3 in ?? () from /usr/lib64/libQtCore.so.4
#16 0x00007f05595553b5 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0
#17 0x00007f05595556e8 in ?? () from /usr/lib64/libglib-2.0.so.0
#18 0x00007f05595557a4 in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0
#19 0x00007f055d400936 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#20 0x00007f055e0c98ae in ?? () from /usr/lib64/libQtGui.so.4
#21 0x00007f055d3d173f in QEventLoop::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#22 0x00007f055d3d19c8 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib64/libQtCore.so.4
#23 0x00007f055d3d63a8 in QCoreApplication::exec() () from /usr/lib64/libQtCore.so.4
#24 0x000000000040887e in main (argc=<optimized out>, argv=<optimized out>) at /home/bogdan/Build/okular/shell/main.cpp:94
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right, was using the wrong observer here, has to be p->observer instead of observer to mimic what the old code did, wonder why wasn't crashing here</pre>
<br />
<p>- Albert</p>
<br />
<p>On February 23rd, 2013, 10:25 p.m. UTC, Albert Astals Cid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular, Aaron J. Seigo, Bogdan Cristea, and Marco Martin.</div>
<div>By Albert Astals Cid.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2013, 10:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make observer.h installable
To make sense in doing that kill the harcoded observer ids, move the priorities to an okular-ui only place and make the pixmap preload easier to access (not depend on random priority values)
We need the m_tiledObserver hack since we only support one tiled observer in the code.
Also kill viewId from View since doesn't make sense either and is unused :-)
Note, there are twohtml pages in the "view diff" page
Marco, Aaron, I haven't tried the active part, could you give it a quick try?
Superceeds https://git.reviewboard.kde.org/r/107047/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, after some tests doesn't seem to crash.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/toc.cpp <span style="color: grey">(bde7c97)</span></li>
<li>ui/minibar.h <span style="color: grey">(185adff)</span></li>
<li>ui/pagepainter.h <span style="color: grey">(42a7313)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(91ae211)</span></li>
<li>ui/pagesizelabel.h <span style="color: grey">(7c4a1e2)</span></li>
<li>ui/pageview.h <span style="color: grey">(d8a7653)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(60a273d)</span></li>
<li>ui/presentationwidget.h <span style="color: grey">(1608ef8)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(35b9d34)</span></li>
<li>ui/priorities.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/side_reviews.h <span style="color: grey">(bbd8324)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(a35f9ed)</span></li>
<li>ui/thumbnaillist.h <span style="color: grey">(20c434f)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(f191274)</span></li>
<li>ui/toc.h <span style="color: grey">(8679648)</span></li>
<li>ui/bookmarklist.h <span style="color: grey">(cb8fcc3)</span></li>
<li>ui/bookmarklist.cpp <span style="color: grey">(e1b3869)</span></li>
<li>active/components/pageitem.cpp <span style="color: grey">(a04a8dc)</span></li>
<li>active/components/pageitem.h <span style="color: grey">(0db4080)</span></li>
<li>active/components/documentitem.cpp <span style="color: grey">(404d863)</span></li>
<li>active/components/documentitem.h <span style="color: grey">(750e5af)</span></li>
<li>CMakeLists.txt <span style="color: grey">(e40cfd6)</span></li>
<li>core/rotationjob_p.h <span style="color: grey">(305e2a1)</span></li>
<li>core/rotationjob.cpp <span style="color: grey">(e26bd6b)</span></li>
<li>core/page_p.h <span style="color: grey">(75575a7)</span></li>
<li>core/page.cpp <span style="color: grey">(4df58e0)</span></li>
<li>core/page.h <span style="color: grey">(6bc60c5)</span></li>
<li>core/observer.h <span style="color: grey">(f7189be)</span></li>
<li>core/generator_p.h <span style="color: grey">(66d4574)</span></li>
<li>core/generator.cpp <span style="color: grey">(402c881)</span></li>
<li>core/generator.h <span style="color: grey">(420bd41)</span></li>
<li>core/document_p.h <span style="color: grey">(57a3bee)</span></li>
<li>core/document.h <span style="color: grey">(1d825e1)</span></li>
<li>core/document.cpp <span style="color: grey">(372af56)</span></li>
<li>core/bookmarkmanager.cpp <span style="color: grey">(accd65f)</span></li>
<li>ui/annotationmodel.cpp <span style="color: grey">(d6d234d)</span></li>
<li>part.h <span style="color: grey">(e3a9418)</span></li>
<li>part.cpp <span style="color: grey">(f1cdc11)</span></li>
<li>generators/spectre/generator_ghostview.cpp <span style="color: grey">(d687d01)</span></li>
<li>generators/chm/generator_chm.cpp <span style="color: grey">(c342a10)</span></li>
<li>generators/chm/generator_chm.h <span style="color: grey">(d87071a)</span></li>
<li>core/view.h <span style="color: grey">(d1fa376)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109115/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>