<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109047/">http://git.reviewboard.kde.org/r/109047/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 19th, 2013, 8:59 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You prefer this over the TryExec solution? Works for me.
Please make sure you commit this to KDE/4.10 first and then merge to master (you'll have to take care the txt backend is only in master)</pre>
</blockquote>
<p>On February 20th, 2013, 9:47 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm, yeah, in this case in distributions if they are packaged separately then only okular desktop is installed the same problem would still occur
will convert to TryExec.
however iirc i think okular active was merged shortly after 4.10, at least i don't have it in KDE/4.10 branch</pre>
</blockquote>
<p>On February 20th, 2013, 9:55 a.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">okular active is definitely there in the KDE/4.10 branch, see http://quickgit.kde.org/?p=okular.git&a=tree&hb=fd22b42b264f6f8e35934eb8fb5a6a0e1d1313ae</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah, yeah, i see, okular active was there, but all the mimetypes were in the only desktop file of the app, were moved to different desktop files for generators afterwards.
do i port 4.10 to separate desktop files as well, or leave only master?</pre>
<br />
<p>- Marco</p>
<br />
<p>On February 19th, 2013, 8:04 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 19, 2013, 8:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this should solve https://bugs.kde.org/show_bug.cgi?id=314981
when the active app is not compiled the active desktop files don't get installed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tried to install both with and without active_found</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e40cfd6)</span></li>
<li>active/CMakeLists.txt <span style="color: grey">(1a8ff74)</span></li>
<li>generators/chm/CMakeLists.txt <span style="color: grey">(e54affc)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(4df23a6)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: grey">(8ca545c)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: grey">(30b7394)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(f076ed9)</span></li>
<li>generators/fax/CMakeLists.txt <span style="color: grey">(f3a321c)</span></li>
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(4fe3877)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: grey">(b0a61eb)</span></li>
<li>generators/ooo/CMakeLists.txt <span style="color: grey">(5d11daf)</span></li>
<li>generators/plucker/CMakeLists.txt <span style="color: grey">(c376467)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: grey">(0964fff)</span></li>
<li>generators/spectre/CMakeLists.txt <span style="color: grey">(617047a)</span></li>
<li>generators/tiff/CMakeLists.txt <span style="color: grey">(bab056f)</span></li>
<li>generators/txt/CMakeLists.txt <span style="color: grey">(5a126b7)</span></li>
<li>generators/xps/CMakeLists.txt <span style="color: grey">(6bd8e58)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109047/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>