<p dir="ltr"><br>
On Feb 18, 2013 2:43 AM, "Albert Astals Cid" <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br>
><br>
> El Dijous, 14 de febrer de 2013, a les 10:41:24, Azat Khuzhin va escriure:<br>
> > Hi Albert,<br>
> ><br>
> > Thanks, I forgot about that places.<br>
> > Fixed.<br>
> ><br>
> > Maybe I need to push this patch to <a href="http://git.reviewboard.kde.org">git.reviewboard.kde.org</a> ?<br>
><br>
> That would help me keeping track of stuff, yes.</p>
<p dir="ltr">I will do this tomorrow. It must as a single commit, or may consist from many?</p>
<p dir="ltr">><br>
> Cheers,<br>
> Albert<br>
><br>
> ><br>
> > On Thu, Feb 14, 2013 at 3:08 AM, Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br>
> > > El Dijous, 14 de febrer de 2013, a les 01:15:39, Azat Khuzhin va escriure:<br>
> > >> Hi all,<br>
> > >><br>
> > >> I found Okular::TextDocumentGenerator, so I fully rewrite current txt<br>
> > >> backend using Okular::TextDocumentGenerator<br>
> > >> And code become pretty clear now.<br>
> > >><br>
> > >> Patch available here<br>
> > >> <a href="https://github.com/azat/okular/compare/master...add-txt-support.patch">https://github.com/azat/okular/compare/master...add-txt-support.patch</a><br>
> > >><br>
> > >> Human view here<br>
> > >> <a href="https://github.com/azat/okular/compare/master...add-txt-support">https://github.com/azat/okular/compare/master...add-txt-support</a><br>
> > ><br>
> > > Document::toUnicode will crash if the prober doesn't give you enough<br>
> > > confidence and you return "" in detectEncoding<br>
> > ><br>
> > > Also i don't see why you need to cache m_detectedEncoding since toUnicode<br>
> > > is only called from the document constructor.<br>
> > ><br>
> > > Cheers,<br>
> > ><br>
> > > Albert<br>
> > >><br>
> > >> New screenshot available here:<br>
> > >> <a href="http://i.imgur.com/YZEmlg0.png">http://i.imgur.com/YZEmlg0.png</a><br>
> > >><br>
> > >> Any wishes?<br>
> > >><br>
> > >> On Wed, Feb 13, 2013 at 8:48 AM, Azat Khuzhin <<a href="mailto:dohardgopro@gmail.com">dohardgopro@gmail.com</a>><br>
> wrote:<br>
> > >> > On Wed, Feb 13, 2013 at 3:06 AM, Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>><br>
> wrote:<br>
> > >> >> El Dilluns, 11 de febrer de 2013, a les 11:14:33, Azat Khuzhin va<br>
> > ><br>
> > > escriure:<br>
> > >> >>> On Mon, Feb 11, 2013 at 1:15 AM, Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>><br>
> > ><br>
> > > wrote:<br>
> > >> >>> > El Diumenge, 10 de febrer de 2013, a les 21:34:35, Azat Khuzhin va<br>
> > >> >><br>
> > >> >> escriure:<br>
> > >> >>> >> Hi all,<br>
> > >> >>> ><br>
> > >> >>> > Hi<br>
> > >> >>> ><br>
> > >> >>> >> I write simple plain text backend for okular.<br>
> > >> >>> >> <a href="https://github.com/azat/okular/tree/add-txt-support">https://github.com/azat/okular/tree/add-txt-support</a><br>
> > >> >>> ><br>
> > >> >>> > To be honest i don't see what benefit a plain text backend for<br>
> > >> >>> > okular<br>
> > >> >>> > has,<br>
> > >> >>> > but I'm not going to try to stop you :-)<br>
> > >> >>><br>
> > >> >>> I use okular to read books, and I have one book in plaintext format,<br>
> > >> >>> but kate doesn't the best choice to read books, so I start<br>
> > >> >>> implementing this backend.<br>
> > >> >><br>
> > >> >> Makes sense, do you have a screenshot we can see how it is looking<br>
> > >> >> like?<br>
> > >> ><br>
> > >> > <a href="http://i.imgur.com/gX0DEJJ.png">http://i.imgur.com/gX0DEJJ.png</a><br>
> > >> > Is this enough?<br>
> > >> ><br>
> > >> >> One of the things i think you'll need to implement is a font selector,<br>
> > >> >> no? So you can change font size, etc. That's one of the things we've<br>
> > >> >> been needing for lots of other "text based" formats, so it'd be cool<br>
> > >> >> to<br>
> > >> >> get globally :-)><br>
> > >> ><br>
> > >> > Good idea.<br>
> > >> > I will do this in the next week. More likely after some<br>
> > >> > refactoring/improvements of new plain text backend.<br>
> > >> ><br>
> > >> >>> >> I will support this backend until bringing it to a normal state.<br>
> > >> >>> >> It means I will resolv many TODO's in this code, that I left, and<br>
> > >> >>> >> do<br>
> > >> >>> >> some refactoring.<br>
> > >> >>> >><br>
> > >> >>> >> And after some fixes, from time to time, to this backed will write<br>
> > >> >>> >> email to this mail list that new version is available.<br>
> > >> >>> >><br>
> > >> >>> >> It will be great if this backend can be merged to upstream, for<br>
> > >> >>> >> everybody.<br>
> > >> >>> >> So if anybody can tell what must be fixed before merging to<br>
> > >> >>> >> upstream,<br>
> > >> >>> >> I will do it as soon as I can.<br>
> > >> >>> >><br>
> > >> >>> >> Patch available here<br>
> > >> >>> >> <a href="https://github.com/azat/okular/compare/master...add-txt-support.pa">https://github.com/azat/okular/compare/master...add-txt-support.pa</a><br>
> > >> >>> >> tch<br>
> > >> >>> >><br>
> > >> >>> >> Graphic view available here<br>
> > >> >>> >> <a href="https://github.com/azat/okular/compare/master...add-txt-support">https://github.com/azat/okular/compare/master...add-txt-support</a><br>
> > >> >>> ><br>
> > >> >>> > Any reason this is happening in github instead of in <a href="http://git.kde.org">git.kde.org</a>?<br>
> > >> >>> > You'll<br>
> > >> >>> > probably get more help/visibility if in <a href="http://git.kde.org">git.kde.org</a> than in github<br>
> > >> >>><br>
> > >> >>> I use github for open source development.<br>
> > >> >>> It doesn't take much to push to <a href="http://git.kde.org">git.kde.org</a> too.<br>
> > >> >>><br>
> > >> >>>ceil<br>
> > >> >>><br>
> > >> >>> I'v registered at <a href="http://identity.kde.org">identity.kde.org</a> and now I have <a href="http://git.kde.org">git.kde.org</a><br>
> > >> >>> account.<br>
> > >> >>> But I don't know how can I create repository there.<br>
> > >> >>> Could you help me with this?<br>
> > >> >><br>
> > >> >> Sadly you can't, you need a "contributor account" and for that there<br>
> > >> >> is a<br>
> > >> >> requirement you have contributed some patches before getting the<br>
> > >> >> account,<br>
> > >> >> so i guess for now you'll still need to be in github, sorry for the<br>
> > >> >> incorrect information :-/<br>
> > >> ><br>
> > >> > Don't worry, I will use github.<br>
> > >> > I will push to new repository when I will get "contributor account".<br>
> > >> ><br>
> > >> >> Cheers,<br>
> > >> >><br>
> > >> >> Albert<br>
> > >> >><br>
> > >> >>> > Cheers,<br>
> > >> >>> ><br>
> > >> >>> > Albert<br>
> > >> >>> >><br>
> > >> >>> >> P.S. I will gladly except you help with development.<br>
> > >> >>> >><br>
> > >> >>> >> --<br>
> > >> >>> >> Azat Khuzhin<br>
> > >> >>> >> Primary email: <a href="mailto:a3at.mail@gmail.com">a3at.mail@gmail.com</a><br>
> > >> >>> >> _______________________________________________<br>
> > >> >>> >> Okular-devel mailing list<br>
> > >> >>> >> <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > >> >>> >> <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> > >> >>> ><br>
> > >> >>> > _______________________________________________<br>
> > >> >>> > Okular-devel mailing list<br>
> > >> >>> > <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > >> >>> > <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> > >> >>><br>
> > >> >>> --<br>
> > >> >>> Azat Khuzhin<br>
> > >> >>> Primary email: <a href="mailto:a3at.mail@gmail.com">a3at.mail@gmail.com</a><br>
> > >> >>> _______________________________________________<br>
> > >> >>> Okular-devel mailing list<br>
> > >> >>> <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > >> >>> <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> > >> >><br>
> > >> >> _______________________________________________<br>
> > >> >> Okular-devel mailing list<br>
> > >> >> <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > >> >> <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> > >> ><br>
> > >> > --<br>
> > >> > Azat Khuzhin<br>
> > >> > Primary email: <a href="mailto:a3at.mail@gmail.com">a3at.mail@gmail.com</a><br>
> > >><br>
> > >> --<br>
> > >> Azat Khuzhin<br>
> > >> Primary email: <a href="mailto:a3at.mail@gmail.com">a3at.mail@gmail.com</a><br>
> > >> _______________________________________________<br>
> > >> Okular-devel mailing list<br>
> > >> <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > >> <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> > ><br>
> > > _______________________________________________<br>
> > > Okular-devel mailing list<br>
> > > <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > > <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> ><br>
> > --<br>
> > Azat Khuzhin<br>
> > Primary email: <a href="mailto:a3at.mail@gmail.com">a3at.mail@gmail.com</a><br>
> > _______________________________________________<br>
> > Okular-devel mailing list<br>
> > <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> > <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
> _______________________________________________<br>
> Okular-devel mailing list<br>
> <a href="mailto:Okular-devel@kde.org">Okular-devel@kde.org</a><br>
> <a href="https://mail.kde.org/mailman/listinfo/okular-devel">https://mail.kde.org/mailman/listinfo/okular-devel</a><br>
</p>