<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107429/">http://git.reviewboard.kde.org/r/107429/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 91e46331fd7901705a69323c75de84e2467416dd by Luigi Toscano to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 26th, 2012, 11:45 p.m., Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2012, 11:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch attempts to restore the functionalities broken by some changes (maybe the text column selection code).
It uses a bit of heuristics to identify the end of a word and merge the boxes which enclose each character of a word (so that char_x.right==char_{x+1}.left). It also try to recognize if there is a newline ("after_space") after that a space is found.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested the faulty document from the bug, and the usual dvistd0.dvi and KDVI-features.dvi.
Tested against KDE/4.9; the patch applies to master but I didn't try it there (but dvi code did not change at all).
What is still not working?
- a isolated comma or dot is seen on a separate line (because its height does not match the rest of the line). I think that this is a problem with the algorithm which recognize the lines, as (with this patch) the information about blocks of characters are correctly passed by the dvi generator.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302004">302004</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/dvi/dviRenderer_draw.cpp <span style="color: grey">(b816353)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107429/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>