<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107357/">http://git.reviewboard.kde.org/r/107357/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The QFormLayout is not needed, that's a class totally tailored for small screen state devices (phones) and it's not going to happen that we port this dialog to a phone.
The icon thing looks like a nice addition and i don't object to the showing of the comment either,</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 17th, 2012, 10:56 a.m., Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated Nov. 17, 2012, 10:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes the properties dialog to use QFormLayout instead of a two-column QGridLayout. This should make the dialog more compatible with other user interfaces.
For the mime type row, instead of just showing the mime type's name, a small QLabel is used to show the mime type's icon.
Maybe it would be a good idea to not only show the mime type's name, but also the description (KMimeType::comment(..)). Example: "PDF Document (application/pdf)"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/propertiesdialog.cpp <span style="color: grey">(2ef8220)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107357/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107357/s/835/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/17/okular-mimetype_400x100.png" style="border: 1px black solid;" alt="QFormLayout and mime type icon" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>