<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107350/">http://git.reviewboard.kde.org/r/107350/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, as commented on IRC we are feature frozen for 4.10 and as we don't have a 4.11 branch can't commit this. Will do once we reopen master branch for 4.11 development.
Thanks!</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 16th, 2012, 10:33 p.m., Thomas Fischer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Thomas Fischer.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2012, 10:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes Okular not only show a document's size (width x height) in inches or millimeters, but it will try to guess the paper format's name as well.
Example: So far, for an opened PDF file in the Properties dialog (File -> Properties), it would print "Page Size: 210,016 x 297,011 mm". Using this patch, it would say instead "210,016 x 297,011 mm (portrait ISO/DIN A4)"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works for example files using format ISO/DIN A4 and legal. No example files for other formats available (e.g. Japanese JIS-B or tabloid).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.cpp <span style="color: grey">(3e4e21a)</span></li>
<li>core/document_p.h <span style="color: grey">(4a20561)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107350/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107350/s/834/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/16/papername_400x100.png" style="border: 1px black solid;" alt="Showing paper format "portrait ISO/DIN A4"" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>