<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103060/">http://git.reviewboard.kde.org/r/103060/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 12th, 2012, 12:03 a.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Michel, I want to apoligize, I've been ultra busy with lots of other stuff and could not make the review in time for this to be included in the 4.10 release. It is totally my fault, I will try to get it in 4.11. I hope this is not blocking the kile release that has live preview, right?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Albert,
don't worry, I've also been extremely busy in the last weeks and I might not even have had the time to do any more changes to the patch if they had been required.
This patch doesn't block the live preview feature but I noticed that I might need a few more functions in the ViewerInterface; hence, I might have to come up with a ViewerInterface2... ;)</pre>
<br />
<p>- Michel</p>
<br />
<p>On September 26th, 2012, 8:16 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated Sept. 26, 2012, 8:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement the handling of page rotations for source references.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.h <span style="color: grey">(d47acec)</span></li>
<li>core/document.cpp <span style="color: grey">(7f006e6)</span></li>
<li>core/page.h <span style="color: grey">(a8f2761)</span></li>
<li>core/page.cpp <span style="color: grey">(d746382)</span></li>
<li>core/utils.h <span style="color: grey">(8d5d5fc)</span></li>
<li>core/utils.cpp <span style="color: grey">(5dd8448)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(5cd327f)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(fcc8dc4)</span></li>
<li>part.cpp <span style="color: grey">(2ef39d8)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(537e5c5)</span></li>
<li>ui/pageview.h <span style="color: grey">(9f56620)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(496abdc)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(a35f9ed)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(60288cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>