<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106930/">http://git.reviewboard.kde.org/r/106930/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 17th, 2012, 9:56 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/106930/diff/1/?file=90978#file90978line22" style="color: black; font-weight: bold; text-decoration: underline;">generators/xps/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">install( FILES libokularGenerator_xps.desktop okularXps.desktop DESTINATION ${SERVICES_INSTALL_DIR} )</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">install( FILES libokularGenerator_xps.desktop okularXps.desktop <span class="hl">active-documentviewer_xps.desktop </span>DESTINATION ${SERVICES_INSTALL_DIR} )</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why the active-documentviewer_xps in both install lines?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whops, that's was just forgotten, corrected also a similar issue in the dvi one</pre>
<br />
<p>- Marco</p>
<br />
<p>On October 18th, 2012, 9:09 a.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 18, 2012, 9:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">splits the desktop file of the active app per mimetype, as is done for the desktop version and for the part, so only the ones that were actually built will be supported</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/app/active-documentviewer.desktop <span style="color: grey">(66c751e)</span></li>
<li>generators/chm/CMakeLists.txt <span style="color: grey">(3f28603)</span></li>
<li>generators/chm/active-documentviewer_chm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(067a07a)</span></li>
<li>generators/comicbook/active-documentviewer_comicbook.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: grey">(dc9b998)</span></li>
<li>generators/djvu/active-documentviewer_djvu.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: grey">(d517b42)</span></li>
<li>generators/dvi/active-documentviewer_dvi.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(f05bf38)</span></li>
<li>generators/epub/active-documentviewer_epub.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fax/CMakeLists.txt <span style="color: grey">(79e7faa)</span></li>
<li>generators/fax/active-documentviewer_fax.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(821cdbf)</span></li>
<li>generators/fictionbook/active-documentviewer_fb.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/kimgio/CMakeLists.txt <span style="color: grey">(07d9f0c)</span></li>
<li>generators/ooo/CMakeLists.txt <span style="color: grey">(2496fbb)</span></li>
<li>generators/ooo/active-documentviewer_ooo.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/plucker/CMakeLists.txt <span style="color: grey">(c79d59a)</span></li>
<li>generators/plucker/active-documentviewer_plucker.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/poppler/CMakeLists.txt <span style="color: grey">(78885fc)</span></li>
<li>generators/poppler/active-documentviewer_pdf.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/spectre/CMakeLists.txt <span style="color: grey">(d3d6f80)</span></li>
<li>generators/spectre/active-documentviewer_ghostview.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/tiff/CMakeLists.txt <span style="color: grey">(31186ea)</span></li>
<li>generators/tiff/active-documentviewer_tiff.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/xps/CMakeLists.txt <span style="color: grey">(50eec71)</span></li>
<li>generators/xps/active-documentviewer_xps.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106930/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>