<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104947/">http://git.reviewboard.kde.org/r/104947/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7ce6990098755f5318bac5747178ee8a2c9213d4 by Bogdan Cristea to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 6th, 2012, 12:49 p.m., Bogdan Cristea wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Bogdan Cristea.</div>
<p style="color: grey;"><i>Updated Oct. 6, 2012, 12:49 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Default settings file should be separated in two different files in order to have a better separation between okular core library (back end) and the front end (https://bugs.kde.org/show_bug.cgi?id=299526). This review request includes only the separation of okular.kcfg in two files:
-okular.kcfg (front end)
-okular_core.kcfg (back end)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a057e82)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(9174733)</span></li>
<li>conf/okular_core.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>conf/settings.kcfgc <span style="color: grey">(0b70390)</span></li>
<li>conf/settings_core.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>core/document.cpp <span style="color: grey">(143d598)</span></li>
<li>core/script/kjs_fullscreen.cpp <span style="color: grey">(c07ac4e)</span></li>
<li>core/texteditors_p.h <span style="color: grey">(171dc69)</span></li>
<li>okular.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>okular_sep_settings.pl <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(537e5c5)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(2ef10a1)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(9ba942b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104947/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>