<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106761/">http://git.reviewboard.kde.org/r/106761/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does it have to be the ffmpegthumbnailer specifically? Afaik there's another video thumbnailer around, isn't there a generic kde mechanism to ask for the installed video thumbnailer and use that one?</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 8th, 2012, 8:48 a.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2012, 8:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the old implementation the Phonon::VideoWidget::snapshot() method was used to create the first-frame (poster) images for a movie, however the Phonon API and the backends (gstreamer and vlc) provide no reliable way to take the snapshot of the first frame. For this reason this patch adds an additional option to use the libffmpegthumbnailer library to take the snapshot of the first frame.
It is faster than using the VideoWidget::snapshot() method and always returns the requested frame.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/CMakeLists.txt <span style="color: grey">(b80c447)</span></li>
<li>ui/config-snapshot-method.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/snapshottaker.h <span style="color: grey">(e34c3e0)</span></li>
<li>ui/snapshottaker.cpp <span style="color: grey">(362d249)</span></li>
<li>CMakeLists.txt <span style="color: grey">(a057e82)</span></li>
<li>cmake/modules/FindFfmpegThumbnailer.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>