<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106666/">http://git.reviewboard.kde.org/r/106666/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 3rd, 2012, 10:41 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Little summary since the other block is getting huge :D
* Messages.sh tweaking after merge
* .desktop for format support tweaking after merge
* Bookmark viewport vs page number
* Pagepainter API to disable AA
I think we can leave the pagepainter change for after the merge too, not sure about the bookmark thing since it's "public qml API" related, not that we have to promise API stability on the QML side either...
So what do you say, you want to me to merge now or finish the fixup these things?</pre>
</blockquote>
<p>On October 4th, 2012, 12:14 a.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah, there's also the issue that i get this on running
file:///home/kdeunstable/instalado/share/apps/plasma/packages/org.kde.active.documentviewer/contents/ui/main.qml:22:1: module "org.kde.plasma.extras" is not installed
import org.kde.plasma.extras 0.1 as PlasmaExtras
</pre>
</blockquote>
<p>On October 4th, 2012, 1:30 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with qmlviewer or with the compiled app?
the plasmaextras import exists since 4.9, so it should work
if it's with qmlviewer it's known, because it doesn't know where the import folder is (we can't use the global hardcoded /usr/imports since we have to respect the install prefix)
so qml files using any import from org.kde.* needs qmlviewer -I prefix/lib/kde4/imports filename.qml</pre>
</blockquote>
<p>On October 4th, 2012, 1:36 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">something that i would like to do before merge still is the bookmark management (since may require quite some changes in the qml part as well, still not sure how much invasive).
how do you think it should be done? ie, how would you expose the bookmarks in qml?
i still don't have clear exactly what a bookmark url represents, so i need a more informed idea ;)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the import thing, was a PEBKAC.
About the bookmarks, well, a bookmarl url represents the url to the document and the viewport to move to the document. DocumentViewport knows how to handle that you shouldn't need to know more, just feed it to the document and that's it.
Also there is the binding loop we talked about on IRC that would be good if was fixed before merging.</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 3rd, 2012, 10:17 a.m., Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2012, 10:17 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch provides some QML imports org.kde.okular.* to use some features of okularcore directly from qml (basically, components for documents and page rendering)
Then there is a small application, mostly QML, that use those components to build a document reader optimized for touch devices, used on Plasma Active</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a057e82)</span></li>
<li>active/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/active-documentviewer.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Bookmarks.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Browser.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/FullScreenDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/TableOfContents.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/Thumbnails.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/ThumbnailsBase.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/TreeDelegate.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/bookmark.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/bookmark.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/src/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/app/src/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/documentitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/documentitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/okularplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/okularplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/pageitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/pageitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/thumbnailitem.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/thumbnailitem.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/tocmodel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>active/components/tocmodel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106666/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>