<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103060/">http://git.reviewboard.kde.org/r/103060/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 25th, 2012, 9:44 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, i'm a bit confused again, sorry for that, but reading the patch (I'm really trying to get it in for 4.10) and it says
For document::setViewport
Note that coordinates given in @p viewport must be relative to Rotation0.
But then in Part::slotGotoLast() we actually give different x, y depending on the rotation, but shouldn't we always pass 0,1 if we need to pass them based on the Rotation0?</pre>
</blockquote>
<p>On September 25th, 2012, 10:12 p.m., <b>Michel Ludwig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This refers to the question of what Part::slotGotoLast() is supposed to do :)
If I remember correctly, I took it as "move the horizontal scrollbar as far left as possible, and the vertical one as far down as possible", and that point then depends on the current rotation.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure, but if the documentation says that setViewport has to be on Rotation0 coordinates shouldn't it just be 0,1? Otherwise what does the mention of Rotation0 in setViewport mean?</pre>
<br />
<p>- Albert</p>
<br />
<p>On September 18th, 2012, 9:08 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2012, 9:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement the handling of page rotations for source references.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.h <span style="color: grey">(85cd821)</span></li>
<li>core/document.cpp <span style="color: grey">(9d6b25c)</span></li>
<li>core/page.h <span style="color: grey">(a8f2761)</span></li>
<li>core/page.cpp <span style="color: grey">(d746382)</span></li>
<li>core/utils.h <span style="color: grey">(8d5d5fc)</span></li>
<li>core/utils.cpp <span style="color: grey">(5dd8448)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(5cd327f)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(c63753e)</span></li>
<li>part.cpp <span style="color: grey">(fe11189)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(537e5c5)</span></li>
<li>ui/pageview.h <span style="color: grey">(8cf8844)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(d3e1888)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(a35f9ed)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(60288cb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>