<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105965/">http://git.reviewboard.kde.org/r/105965/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just realized we are not doing it right, the close action should be in of the shell, not of the part (as the open action is in the shell and not in the part).
Can you have a look for that? This way you won't need the part.rc modification.
The only issue i can see is knowing the file was closed internally (by those of one links we talked about earlier) but i guess you can always add a signal to the part and connect from the shell.</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 15th, 2012, 10:05 p.m., Jaydeep Solanki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jaydeep Solanki.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2012, 10:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
Opens a new instance of Okular for every other file that is opened.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.h <span style="color: grey">(d9a5cc4)</span></li>
<li>part.cpp <span style="color: grey">(7c1ca71)</span></li>
<li>part.rc <span style="color: grey">(33d3829)</span></li>
<li>shell/shell.cpp <span style="color: grey">(8b42a27)</span></li>
<li>shell/shell.rc <span style="color: grey">(93fbc41)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>