<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105890/">http://git.reviewboard.kde.org/r/105890/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still can't get it to work (getting phonon configured is not as easy as i'd like) but since i guess it's working for Olivier (otehrwise how did he do the suggestions) and for you too, that makes it more than 1 and the code is not ultra-ugly so feel free to commit (master only please)</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 15th, 2012, 10:19 a.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2012, 10:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch extends the VideoWidget to either show the actual video player and keep it hidden while not playing (in non-poster mode) or show an image of the first frame all the time and overlay it with the video player (in poster mode).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using the files provided as attachment in https://bugs.kde.org/show_bug.cgi?id=301603</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e4cb88f)</span></li>
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(ffa6950)</span></li>
<li>core/movie.h <span style="color: grey">(cbe382e)</span></li>
<li>core/movie.cpp <span style="color: grey">(94e71a9)</span></li>
<li>generators/poppler/config-okular-poppler.h.cmake <span style="color: grey">(df89d68)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(71c962c)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(bcb4795)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(f4da539)</span></li>
<li>ui/snapshottaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/snapshottaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/videowidget.h <span style="color: grey">(e82753c)</span></li>
<li>ui/videowidget.cpp <span style="color: grey">(7d80b43)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105890/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>