<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105890/">http://git.reviewboard.kde.org/r/105890/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 8th, 2012, 10:22 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just gave it a try with the file of the attached bug and noticed two things:
a) It doesn't work, i don't get any poster image
b) I get for a while a "flying" widget over the okular window (argably the snapshot taker)
Does it work for you? Which phonon are you using?</pre>
</blockquote>
<p>On August 10th, 2012, 1:05 p.m., <b>Tobias Koenig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have to use a phonon backend that supports the snapshot() method in its VideoWidget interface. That's the case for the latest version of the vlc-backend (which I also use).
Do you use gstreamer?</pre>
</blockquote>
<p>On August 10th, 2012, 9 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does my phonon backend support snapshot()? -> No clue, how do i know?
Do I use gstreamer -> Yes
Can we detect that snapshot() support and if not there do not popup ugly widgets in my face?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hej Albert,
the popup comes from somewhere inside the gstreamer backend... I have no influence on that behaviour via the public phonon API.
Nevertheless taking the actual snapshot with the gstreamer backend works fine for me here. Looking at the phonon-gstreamer code shows that the snapshot functionality in gstreamer is only available when compiled against at least 0.10.31. Do you have that or a newer version installed (look at /usr/include/gstreamer-0.10/gst/pbutils/gstpluginsbaseversion.h)?
Unfortunately Phonon does not provide any public API to check whether the backend really supports/implements the snapshot functionality. The default implementation simply returns an empty QImage().
Ciao,
Tobias</pre>
<br />
<p>- Tobias</p>
<br />
<p>On August 8th, 2012, 9:23 a.m., Tobias Koenig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Tobias Koenig.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2012, 9:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch extends the VideoWidget to either show the actual video player and keep it hidden while not playing (in non-poster mode) or show an image of the first frame all the time and overlay it with the video player (in poster mode).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using the files provided as attachment in https://bugs.kde.org/show_bug.cgi?id=301603</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e4cb88f)</span></li>
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(ffa6950)</span></li>
<li>core/movie.h <span style="color: grey">(cbe382e)</span></li>
<li>core/movie.cpp <span style="color: grey">(94e71a9)</span></li>
<li>generators/poppler/config-okular-poppler.h.cmake <span style="color: grey">(df89d68)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(71c962c)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(b74941d)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(f4da539)</span></li>
<li>ui/snapshottaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/snapshottaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>ui/videowidget.h <span style="color: grey">(e82753c)</span></li>
<li>ui/videowidget.cpp <span style="color: grey">(7d80b43)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105890/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>