<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105965/">http://git.reviewboard.kde.org/r/105965/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2012, 11:17 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"because there was no way to close the document"
That's totally incorrect, there's lots of ways of a document being closed. Have a look at all the possible calls to closeUrl in Part? How do you handle these?</pre>
</blockquote>
<p>On August 13th, 2012, 3:25 a.m., <b>Jaydeep Solanki</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not that, yes you can close the document programmatically, but that was not possible by the user. Like if I have one instance of Okular with Harry Potter opened, and if I want to open another book in the same instance, I can only do that after closing Harry Potter. So for the convenience of the user I have provided the "Close Document" action in File Menu, with that he can close the current document and open another document in the same instance.
If I don't provide it, whenever the user try to open new document, he would have to "Quit" okular, and open it again, because till now there was no "close" available to user, there was only the "Quit" option.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are not reading the code correctly. There are ways the user can close the document, e.g. if the document provides a close action link. How do you handle that?</pre>
<br />
<p>- Albert</p>
<br />
<p>On August 12th, 2012, 9:31 p.m., Jaydeep Solanki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jaydeep Solanki.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2012, 9:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is a fix for the bug-166645, as listed here (https://bugs.kde.org/show_bug.cgi?id=166645)
Opens a new instance of Okular for every other file that is opened.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.h <span style="color: grey">(d9a5cc4)</span></li>
<li>part.cpp <span style="color: grey">(7c1ca71)</span></li>
<li>part.rc <span style="color: grey">(33d3829)</span></li>
<li>shell/shell.h <span style="color: grey">(8430b9c)</span></li>
<li>shell/shell.cpp <span style="color: grey">(8b42a27)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>