<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103427/">http://git.reviewboard.kde.org/r/103427/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2012, 10:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated diff in accordance with review comments. There can now be more than one MiniBar, so there is no need to hide the tool when the page bar is shown and vice versa. Either, both or neither of the tool and/or page bar can be shown independently, and both of them work in the same way.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bug (and duplicates) suggests that the page bar which normally appears at the bottom of the Okular window could be docked in the toolbar, in order to save vertical screen space which is especially useful on a wide screen. This patch implements that.
There can only be one MiniBar in existence, because of the fixed observer ID (which must be unique). So the page tool only appears in the toolbar if the page bar is hidden; if it is shown, then the page number and size label appears there as before. The MiniBar is reparented in Part::slotShowBottomBar() when the page bar is shown or hidden.
The page tool is placed in its own toolbar by default, so that it can be positioned or floated in accordance with the user's preference.
There are GUI changes and a new I18N string, so this change (if accepted) would be targeted at KDE SC 4.8.1 or later.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built Okular from master with these changes. Checked operation in both embedded and standalone modes with page bar shown or not, with a variety of PDF files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279128">279128</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/observer.h <span style="color: grey">(266993c)</span></li>
<li>part-viewermode.rc <span style="color: grey">(dbd8e42)</span></li>
<li>part.h <span style="color: grey">(a4ab8aa)</span></li>
<li>part.cpp <span style="color: grey">(cd0b695)</span></li>
<li>part.rc <span style="color: grey">(33d3829)</span></li>
<li>ui/minibar.h <span style="color: grey">(e91a0fd)</span></li>
<li>ui/minibar.cpp <span style="color: grey">(7e77dec)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103427/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103427/s/372/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/16/okular-pagetool_1_400x100.png" style="border: 1px black solid;" alt="With page bar shown" /></a>
<a href="http://git.reviewboard.kde.org/r/103427/s/373/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/16/okular-pagetool_2_400x100.png" style="border: 1px black solid;" alt="With page bar hidden" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>