<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103427/">http://git.reviewboard.kde.org/r/103427/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 19th, 2011, 7:30 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103427/diff/1/?file=43529#file43529line71" style="color: black; font-weight: bold; text-decoration: underline;">ui/pagesizelabel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PageSizeLabel::notifyViewportChanged( bool /*smoothMove*/ )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">71</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">m_antiWidget</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks unrelated to the feature?</pre>
</blockquote>
<p>On December 19th, 2011, 9:29 p.m., <b>Jonathan Marten</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was needed in an earlier version of this change, when it looked as if it was going to be necessary to delete the bottom bar completely when it was not being shown in order to release the MiniBar. However, it is not necessary now - will revert.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Waiting for the new patch...</pre>
<br />
<p>- Albert</p>
<br />
<p>On December 16th, 2011, 1:04 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2011, 1:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bug (and duplicates) suggests that the page bar which normally appears at the bottom of the Okular window could be docked in the toolbar, in order to save vertical screen space which is especially useful on a wide screen. This patch implements that.
There can only be one MiniBar in existence, because of the fixed observer ID (which must be unique). So the page tool only appears in the toolbar if the page bar is hidden; if it is shown, then the page number and size label appears there as before. The MiniBar is reparented in Part::slotShowBottomBar() when the page bar is shown or hidden.
The page tool is placed in its own toolbar by default, so that it can be positioned or floated in accordance with the user's preference.
There are GUI changes and a new I18N string, so this change (if accepted) would be targeted at KDE SC 4.8.1 or later.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built Okular from master with these changes. Checked operation in both embedded and standalone modes with page bar shown or not, with a variety of PDF files.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279128">279128</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part-viewermode.rc <span style="color: grey">(dbd8e42)</span></li>
<li>part.h <span style="color: grey">(cae5af0)</span></li>
<li>part.cpp <span style="color: grey">(b3b4234)</span></li>
<li>part.rc <span style="color: grey">(33d3829)</span></li>
<li>ui/pagesizelabel.cpp <span style="color: grey">(4a80779)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103427/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103427/s/372/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/16/okular-pagetool_1_400x100.png" style="border: 1px black solid;" alt="With page bar shown" /></a>
<a href="http://git.reviewboard.kde.org/r/103427/s/373/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/16/okular-pagetool_2_400x100.png" style="border: 1px black solid;" alt="With page bar hidden" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>