<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103517/">http://git.reviewboard.kde.org/r/103517/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug: If you collapse the sidebar, you'll see there's no current (blue) item in the sidebar, after the file reload, the content item is highlighted in blue, that should ideally not happen, can you have a look?</pre>
<br />
<p>- Albert</p>
<br />
<p>On December 26th, 2011, 10:30 a.m., Elvis Stansvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular and Albert Astals Cid.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2011, 10:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When working on a PDF with the OpenTOC flag set, such as those generated by LaTeX, it's a bit annoying that the Navigation Panel (aka sidebar) keeps popping up, even if it was collapsed.
It is understandable that Okular respects the flag when a file is initially opened, but when working on a document with Okular next to your editor, it's distracting that I repeatedly have to collapse the sidebar again.
This patch:
- Adds a setCollapsed(bool)/isCollapsed() API to Sidebar and
changes relevant places to use the new API.
- Make sure Okular remembers the collapsed state of the
sidebar when a file is automatically reloaded due to a file
change.
Okular will still respect the OpenTOC file when a file is opened the first time, just like before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Tested that Okular will remember the collapsed state of the sidebar when a file is automatically reloaded.
- Tested that Okular will still respect the OpenTOC and show the sidebar+TOC when a file is opened for the first time.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=289010">289010</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part.h <span style="color: grey">(cae5af0)</span></li>
<li>part.cpp <span style="color: grey">(7db0c0b)</span></li>
<li>ui/sidebar.h <span style="color: grey">(60dc7d6)</span></li>
<li>ui/sidebar.cpp <span style="color: grey">(b26d65d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103517/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>