<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103060/">http://git.reviewboard.kde.org/r/103060/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about:
"There are two issues left with it, however:
- 'ThumbnailListPrivate::getNewPageOffset' still has to be updated to work with Rotation180
- There is currently no code for switching pages in either Rotation90 or Rotation270"
Is that done?
Tomorrow (today?) tuesday 20 it is RC1, my question is, do you think this is "better" than what we have and that it'll introduce no regressions? I'm a little worried about it being a big-ish change and since it's been broken for a long time i was thinking that maybe we can leave it for 4.9? What do you think?</pre>
<br />
<p>- Albert</p>
<br />
<p>On December 19th, 2011, 5:06 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 5:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement the handling of page rotations for source references.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.h <span style="color: grey">(df65d52)</span></li>
<li>core/document.cpp <span style="color: grey">(74757f1)</span></li>
<li>core/page.h <span style="color: grey">(46fba72)</span></li>
<li>core/page.cpp <span style="color: grey">(bb3dbbd)</span></li>
<li>core/utils.h <span style="color: grey">(8d5d5fc)</span></li>
<li>core/utils.cpp <span style="color: grey">(5dd8448)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(16d124b)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(7095e47)</span></li>
<li>part.cpp <span style="color: grey">(7db0c0b)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(ca55e81)</span></li>
<li>ui/pageview.h <span style="color: grey">(4a8e287)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(78a007a)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(40a7adf)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(ebaef9c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>