<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103060/">http://git.reviewboard.kde.org/r/103060/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2011, 10:09 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103060/diff/4/?file=41937#file41937line1712" style="color: black; font-weight: bold; text-decoration: underline;">part.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Part::slotGotoFirst()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1712</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">switch</span><span class="p">(</span> <span class="n">m_document</span><span class="o">-></span><span class="n">page</span><span class="p">(</span> <span class="n">m_document</span><span class="o">-></span><span class="n">pages</span><span class="p">()</span> <span class="o">-</span> <span class="mi">1</span> <span class="p">)</span><span class="o">-></span><span class="n">rotation</span><span class="p">()</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use rotateNormalisedToRotation0 here?</pre>
</blockquote>
<p>On December 7th, 2011, 8:23 a.m., <b>Michel Ludwig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It depends on what Part::slotGotoLast is supposed to do. I took it as: move the vertical scroll bar as far down as possible, and the horizontal one as far left as possible.
Hence, the required viewport position relative to Rotation0 changes.
But if you see it differently, I can also change it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No i don't have a different view, but i had a quick but i see that it does
Rotation0 0, 1
Rotation90 1, 1
Rotation180 1, 0
Rotation270 0, 0
And if you apply rotateNormalisedToRotation0 to (0, 1) that will be exactly the results, right?
Ah not, Rotation180 and Rotation270 would be different, ignore me then :D</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 6th, 2011, 10:09 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103060/diff/4/?file=41940#file41940line1007" style="color: black; font-weight: bold; text-decoration: underline;">ui/pageview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PageView::clearLastSourceLocationViewport()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1004</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMetaObject</span><span class="o">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="s">"slotRealNotifyViewportChanged"</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">QueuedConnection</span><span class="p">,</span> <span class="n">Q_ARG</span><span class="p">(</span> <span class="kt">bool</span><span class="p">,</span> <span class="n">smoothMove</span> <span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1007</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QMetaObject</span><span class="o">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="k">this</span><span class="p">,</span> <span class="s">"slotRealNotifyViewportChanged"</span><span class="p">,</span> <span class="n">Qt</span><span class="o">::</span><span class="n">QueuedConnection</span><span class="p">,</span> <span class="n">Q_ARG</span><span class="p">(</span> <span class="n"><span class="hl">Okular</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">DocumentViewport</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">d</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">document</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">viewport</span></span><span class="p"><span class="hl">()</span></span><span class="hl"> </span><span class="p"><span class="hl">),</span></span><span class="hl"> </span><span class="n"><span class="hl">Q_ARG</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="kt">bool</span><span class="p">,</span> <span class="n">smoothMove</span> <span class="p">));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't like the fact that we need to pass the viewport here, i take that you need to pass it because someone is changing it? What we should do is fix the one that is changing it, not pass it to the function.</pre>
</blockquote>
<p>On December 7th, 2011, 8:23 a.m., <b>Michel Ludwig</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, if I remember correctly, it also works fine without storing the viewport. I just thought that it might be safer to store it, but I can change it back if you don't like it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If it works without passing the viewport again, yes, i'd prefer it not to be passed. Can you try it?</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 24th, 2011, 8:36 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2011, 8:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement the handling of page rotations for source references.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>core/document.h <span style="color: grey">(78ce53a)</span></li>
<li>core/document.cpp <span style="color: grey">(b3ddb46)</span></li>
<li>core/page.h <span style="color: grey">(46fba72)</span></li>
<li>core/page.cpp <span style="color: grey">(bb3dbbd)</span></li>
<li>core/utils.h <span style="color: grey">(8d5d5fc)</span></li>
<li>core/utils.cpp <span style="color: grey">(5dd8448)</span></li>
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(16d124b)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(d88da80)</span></li>
<li>part.cpp <span style="color: grey">(dd4f2b5)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(ca55e81)</span></li>
<li>ui/pageview.h <span style="color: grey">(63b0af0)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(82f54d1)</span></li>
<li>ui/side_reviews.cpp <span style="color: grey">(40a7adf)</span></li>
<li>ui/thumbnaillist.cpp <span style="color: grey">(60a43c4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>