<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103129/">http://git.reviewboard.kde.org/r/103129/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You need to modify PresentationWidget::requestPixmaps too and depending on how really really aggressive you want to be ThumbnailListPrivate::slotRequestVisiblePixmaps</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 13th, 2011, 4:04 p.m., Sebastian Rose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Sebastian Rose.</div>
<p style="color: grey;"><i>Updated Nov. 13, 2011, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After discovering that the aggressive behaviour in okular is not that aggressive at all (preloads only the next 2 pages) I've written the attached patch to add a "Greedy" option. It preloads every page into memory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested it on my local system, I'm using the modified okular with the new greedy option checked and don't have any issues so far. The memory requirement for a 580 page (color) PDF file is about 1 GiB, the bulk of it for the pixmaps. Other (e.g. unloading) behaviour is like "Aggressive". It takes a while for the whole document to be prerendered but after that it works as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>conf/dlgperformance.cpp <span style="color: grey">(fd0e30b)</span></li>
<li>conf/dlgperformancebase.ui <span style="color: grey">(b022f56)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(cff5ea5)</span></li>
<li>core/document.cpp <span style="color: grey">(b3ddb46)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(0c0ff98)</span></li>
<li>ui/presentationwidget.cpp <span style="color: grey">(7c3f618)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103129/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>