<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103060/">http://git.reviewboard.kde.org/r/103060/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not convinced by this patch, as far as i understood what you wanted to do is get the generators assume everything was on Rotate0, which is what it actually is, so i don't think the generators should be querying the page rotation at all. That seems wrong.
Personally i think that what is wrong is
const Okular::SourceReference * ref = d->document->dynamicSourceReference( pageItem-> pageNumber(), nX * pageItem->page()->width(), nY * pageItem->page()->height() );
That is using width and height indiscriminately when it is there at the UI level where i think makes more sense to compensate for the rotation of the page.
I'd certainly prefer a patch that does not touch generator implementation at all.
If you need help i might give it a go if you give me some sample files to test.</pre>
<br />
<p>- Albert</p>
<br />
<p>On November 6th, 2011, 6:40 p.m., Michel Ludwig wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Okular.</div>
<div>By Michel Ludwig.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2011, 6:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement the handling of page rotations for source references.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/dvi/generator_dvi.cpp <span style="color: grey">(2bc8641)</span></li>
<li>generators/poppler/generator_pdf.cpp <span style="color: grey">(07937b3)</span></li>
<li>ui/pagepainter.cpp <span style="color: grey">(ca55e81)</span></li>
<li>ui/pageview.h <span style="color: grey">(9fac706)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(eebdf46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103060/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>