[okular] [Bug 460681] Laggy scrolling on high DPI display - profiling indicates excessive copying in PagePainter::paintCroppedPageOnPainter

David Hurka bugzilla_noreply at kde.org
Thu Oct 20 17:30:10 BST 2022


https://bugs.kde.org/show_bug.cgi?id=460681

--- Comment #3 from David Hurka <david.hurka at mailbox.org> ---
(In reply to maximumsomething from comment #0)
> I was going to go ahead and fix these things myself, but I was wondering if
> anyone familiar with the code knows why it was written this way/any gotchas
> that might apply if the deep copies are not made.

I thought I would just mention that I have made
https://invent.kde.org/graphics/okular/-/merge_requests/240 long time ago.
The intention was to simplify the code, just like the title suggests.
I also tried to understand the code, and prepare it for peformance
improvements.

I was not aware of deep copying, actually.
My patch still uses setDevicePixelRatio(), so it actually does not fix this
problem.

Honestly I lost interest in this.
If you want, you may continue the work, or just look at it if it helps you to
understand anything. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list