D10455: Add RTL support for search, copy & paste in pdf

Guy Sheffer noreply at phabricator.kde.org
Fri Mar 25 13:17:52 GMT 2022


guysoft added a comment.


  Hey,
  So I sent a merge request for this, but the issue is now that clazy formatting in the ci/cd of the build requires these too lines be changed to something more readable:
  
    // output a left-to-right section
    for (j = i; j < origTxtOrder.length() && ! origTxtOrder.at(j)->text().isRightToLeft(); ++j) ;
  
  and
  
    for(j = i; j < origTxtOrder.length() && (origTxtOrder.at(j)->text().isRightToLeft() || origTxtOrder.at(j)->text() == QLatin1String(" ")); ++j);
  
  I can't test because when I run this on my ubuntu I get that backends are missing. So I can't really change this stuff.
  
  Can anyone help me out to turn this in to a code block?
  @fahadalsaidi perhaps? Its pretty close to get merged.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: sander, guysoft, davidhurka, yaron, okular-devel, chfanzil, ngraham, anaumann, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20220325/9d312b75/attachment.htm>


More information about the Okular-devel mailing list