[okular] [Bug 456107] Show ... toolbar actions loose all their shortcuts when okularpart configuration is modified.

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=456107

David Hurka <david.hurka at mailbox.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kdelibs-bugs at kde.org
            Summary|Main toolbar keyboard       |Show ... toolbar actions
                   |shortcut throwing an error. |loose all their shortcuts
                   |                            |when okularpart
                   |                            |configuration is modified.
             Status|REPORTED                    |CONFIRMED
           Platform|Archlinux Packages          |unspecified
     Ever confirmed|0                           |1

--- Comment #1 from David Hurka <david.hurka at mailbox.org> ---
Reminds me of Bug 384700.

There a shortcut was reset when the configuration of okularpart was modified,
which happens in response to certain actions.
In particular, “Toggle change colors” changed the configuration, which in turn
caused the shortcut of “Toggle change colors” to be reset.

That bug could have been worked around by avoiding action stuff in response to
configuration changes, in particular by avoiding calls to
refreshActionProperties().
In the end, the bug has been fixed in KXmlGui, and Okular still calls
refreshActionProperties() in response to any configuration changes.

In this case, the shortcut for “Main Toolbar” gets lost when the configuration
of okularpart is modified, too.
You describe the bug for “Show sidebar”, but other actions, which write to the
configuration, like “Change colors” trigger the bug as well.

But this case is also different.
It says “Shortcut for action set with QAction::setShortcut()!”, which was not
the case in Bug 384700.
Also, it deletes any shortcut even if it was already saved to disk.

I think the cause for this bug is refreshActionProperties(), again, and the
fact that “Main Toolbar” is somehow special.
You can notice that you can set a shortcut for this action, but you can not add
it to any toolbar.
The other show ... toolbar actions have the same behavior.

So I think the bug is in KXmlGui, because it handles these show ... toolbars in
some special way.

-- 
You are receiving this mail because:
You are the assignee for the bug.