[okular] [Bug 436710] Playing of Flash-free ("plain") Rich Media annotations

[Michal Vlasák]

https://bugs.kde.org/show_bug.cgi?id=436710

--- Comment #2 from Michal Vlasák <lahcim8 at gmail.com> ---
(In reply to Nate Graham from comment #1)
> Thanks; can you please submit code in the form of a merge request at
> https://invent.kde.org/graphics/okular/-/merge_requests?

It seems that I can't create new merge request normally. Maybe "E-mail a new
merge request to this project" will work, but I didn't try.

I didn't even think this is ready for merge request, yet:
 - it requires changes in poppler, that I didn't yet implement correctly,
 - there may be more to it, and I am probably not entitled to do the decision.

My patch was more or less a rough sketch of what somebody more knowledgeable
may do. For instance, I changed the handling of "Instance::Type*" to allow even
audio (which works fine in Okular IIRC) but I don't know how mismatched the
Flash/Audio/Video type is in real PDFs (there probably was a reason why it was
like set like that).

Another thing I remembered: currently Acrobat uses very similiar code to
Okular's to play Flash video (it no longer uses Flash player). But because
Flash-less Rich Media doesn't normally have controls it emulates it if it finds
a certain "skin" in `/Params`. Doing same in Okular may bring it up to par with
current Acrobat for old documents. Details can be found at
https://gitlab.com/agrahn/media9/-/issues/9#note_554144989.

I also noticed, that Okular currently unconditionally uses first
RichMediaConfiguration, which works for all usual cases, but handling this
generally wouldn't be hard.

All in all, I would like to first get poppler to even allow for the code above
and in the mean time get feedback from you guys to know whether it could work
like this. I didn't even manage to get it running. Is there Okular/Qt way  I
can use to assure myself that I am even running the code I added? I didn't find
success with std::out.

-- 
You are receiving this mail because:
You are the assignee for the bug.