[okular] [Bug 437377] Leaving annotation mode with mouse is complicated

Albert Astals Cid bugzilla_noreply at kde.org
Sat Jun 19 16:59:43 BST 2021


https://bugs.kde.org/show_bug.cgi?id=437377

Albert Astals Cid <aacid at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |21.08
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/230a68d5
                   |                            |37a2f958f72dce162221555ef28
                   |                            |5896f
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Albert Astals Cid <aacid at kde.org> ---
Git commit 230a68d537a2f958f72dce162221555ef285896f by Albert Astals Cid, on
behalf of Simone Gaiarin.
Committed on 19/06/2021 at 14:12.
Pushed by aacid into branch 'master'.

Uncheck mouse mode action when annotation tool selected

When the annotation is unchecked the previous mouse mode is restored.

The slot slotMouseNormalToggled is changed back to its original version
of slotSetMouseNormal given that we needed to pass the checked state
only to detach the annotations, and we do it in the lambda now.
Related: bug 398108

FIXED-IN: 21.08

M  +11   -5    autotests/annotationtoolbartest.cpp
M  +45   -15   part/pageview.cpp
M  +1    -1    part/pageview.h
M  +2    -2    part/pageviewannotator.cpp
M  +4    -1    part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list