[okular] [Bug 421437] cursor is still a pointing hand when scrolling stops after clicking an internal link

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=421437

Nate Graham <nate at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/8b008b02
                   |                            |fc31e20f7c74ab2c25d34160756
                   |                            |c7a92
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Nate Graham <nate at kde.org> ---
Git commit 8b008b02fc31e20f7c74ab2c25d34160756c7a92 by Nate Graham, on behalf
of David Hurka.
Committed on 21/10/2020 at 00:40.
Pushed by ngraham into branch 'release/20.08'.

Fix cursor not updated after clicking internal link

updateCursor() was called by wheelEvent(), which made sense,
because after the wheel event the page will have moved under the cursor.

With smooth scrolling, it makes less sense in wheelEvent(),
because at that point scrolling is still in the future.

scrollContentsBy() appears to be called on every scroll step.
(It is documented to be called at scrollbar value changes, so makes sense.)

This patch removes updateCursor() from wheelEvent(), but adds it to
scrollContentsBy().

I did not check anything out with d->visibleItems, as was indicated it
graphics/okular!176.

M  +5    -2    ui/pageview.cpp

https://invent.kde.org/graphics/okular/commit/8b008b02fc31e20f7c74ab2c25d34160756c7a92

-- 
You are receiving this mail because:
You are the assignee for the bug.