[okular] [Bug 353560] Shift-draw straight annotation line to make vertical/horizontal

David Hurka bugzilla_noreply at kde.org
Thu Jul 16 23:32:47 BST 2020


https://bugs.kde.org/show_bug.cgi?id=353560

David Hurka <david.hurka at mailbox.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Version Fixed In|                            |1.11
      Latest Commit|                            |https://invent.kde.org/grap
                   |                            |hics/okular/commit/34708565
                   |                            |caeb5d5fe9b8c14b9cd0af1a8ab
                   |                            |8d5fe
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from David Hurka <david.hurka at mailbox.org> ---
Git commit 34708565caeb5d5fe9b8c14b9cd0af1a8ab8d5fe by David Hurka.
Committed on 16/07/2020 at 22:32.
Pushed by davidhurka into branch 'release/20.08'.

Add Constrain Angle action for annotation tools, alternative to pressing Shift

This adds a KToggleAction which sets annotation tools to constrain angle mode.
It provides an alternative user interface to the Shift button, which is used to
constrain angles since MR !210.
The action and the Shift button are XOR-ed, i. e. if constrain angle mode is
activated, pressing Shift temporarily disables it.

The action state is remembered accross sessions, for consistency with most
other actions. It should be difficult to check this action without knowing of
its existence, since it is not in any toolbar or menu, just in the action
collection.

The meaning of AnnotatorEngine::Modifiers was generalized a bit, moving the
responsibility about whether to constrain angles back to PageViewAnnotator,
because AnnotatorEngine does not know about the action.
FIXED-IN: 1.11

M  +4    -7    doc/index.docbook
M  +23   -2    ui/annotationactionhandler.cpp
M  +2    -6    ui/annotationtools.cpp
M  +4    -3    ui/annotationtools.h
M  +23   -6    ui/pageviewannotator.cpp
M  +11   -0    ui/pageviewannotator.h
M  +1    -1    ui/presentationwidget.cpp

https://invent.kde.org/graphics/okular/commit/34708565caeb5d5fe9b8c14b9cd0af1a8ab8d5fe

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Okular-devel mailing list