D25484: Enable closing a tab by middle click

Bob Bai noreply at phabricator.kde.org
Mon Nov 25 16:24:55 GMT 2019


bdbai added a comment.


  In D25484#567258 <https://phabricator.kde.org/D25484#567258>, @ngraham wrote:
  
  > Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo last closed tab" feature is for these other cases.
  
  
  Based on this feature, can we assume a closed tab has no unsaved changes? If that is the case, we might no need any associated data (except url) to serialize for reopening this tab.
  Another thing is, how many closed tabs should be saved in memory?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191125/8f2a0cf2/attachment.html>


More information about the Okular-devel mailing list