D21971: Replace ToolAction by ToggleActionMenu

[David Hurka]

davidhurka added a comment.


  In D21971#564195 <https://phabricator.kde.org/D21971#564195>, @ngraham wrote:
  
  > Sorry, what is it that you'd like my input on?
  
  
  No problem. :) It’s about the popup modes of the toolbar buttons. We recognized that InstantPopup is useless for ToggleActionMenu, because then it has just the functionality of KSelectAction, so one could use that instead. So InstantPopup is excluded by a custom enum `ToggleActionMenu::PopupMode` now.
  
  But I am unsure whether this is an oppurtunity to ban DelayedPopup as well, because we already recognized earlier that it is annoying in many cases. (Like for ToolAction, we changed it to MenuButtonPopup recently.)
  
  So the question is: When InstantPopup is excluded, should DelayedPopup be excluded as well?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191118/2f5b4c24/attachment.html>