D21971: Replace ToolAction by ToggleActionMenu

[David Hurka]

davidhurka updated this revision to Diff 69549.
davidhurka added a comment.


  - Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum
  
  Honestly, I’m not sure whether this is good. We say no one wants to use InstantPopup, but as well we could say no one wants DelayedPopup.
  @ngraham?

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21971?vs=69368&id=69549

BRANCH
  create-configurable-toggleactionmenu

REVISION DETAIL
  https://phabricator.kde.org/D21971

AFFECTED FILES
  CMakeLists.txt
  ui/pageview.cpp
  ui/toggleactionmenu.cpp
  ui/toggleactionmenu.h
  ui/toolaction.cpp
  ui/toolaction.h

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191110/fede8552/attachment.html>