D21416: Add icons for line annotation arrow styles to combo box

Nathaniel Graham noreply at phabricator.kde.org
Tue May 28 04:05:46 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> annotationwidgets.cpp:538
> +            {
> +                TermStyleEntry { Okular::LineAnnotation::TermStyle::Square, i18n( "Square" ) },
> +                TermStyleEntry { Okular::LineAnnotation::TermStyle::Circle, i18n( "Circle" ) },

Would it make sense to put all of this in a const variable outside of the loop?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21416

To: tobiasdeiminger, #okular
Cc: knambiar, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190528/364e5780/attachment.html>


More information about the Okular-devel mailing list