D18358: Add buttons to collapse and expand all elements

David Hurka noreply at phabricator.kde.org
Sat May 25 13:15:43 BST 2019


davidhurka added inline comments.

INLINE COMMENTS

> side_reviews.cpp:156
> +    connect(expandAll, &QAction::triggered, this, &Reviews::slotExpandAll);
> +    QAction * collapseAll = toolBar->addAction( QIcon::fromTheme( QStringLiteral("collapse-all") ), i18n( "Collapse all elements" ) );
> +    connect(collapseAll, &QAction::triggered, this, &Reviews::slotCollapseAll);

Something is wrong with this icon, it does not change to a light foreground color at a dark theme.
F6848602: Screenshot_2019-05-25_12:12:09.png <https://phabricator.kde.org/F6848602>
It’s not because like it is disabled, it’s always that dark.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18358

To: joaonetto, #okular, #vdg, ngraham, aacid
Cc: davidhurka, ndavis, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190525/b9e8ff29/attachment-0001.html>


More information about the Okular-devel mailing list