[okular] [Bug 334297] Highlighter of the review tool does not work correct in rotated views of the pdf document

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=334297

--- Comment #3 from David Hurka <david.hurka at mailbox.org> ---
Created attachment 120266
  --> https://bugs.kde.org/attachment.cgi?id=120266&action=edit
Where the highlighting goes if the view is rotated

Explaining the issue with a screenshot.

Seems like Okular passes the wrong RegularAreaRect to the highlighter tool, a
RegularAreaRect that somehow got the page rotation applied.

More explanation (for non-Okular-developers):
* A RegularAreaRect is an object which describes an area on the page,
consisting of N NormalizedRect objects.
* A NormalizedRect is an object which describes a rectangular area on the page,
using normalized coordinates.
* Normalized coordinates go from 0 to 1, where 0 is one edge of the page, and 1
the opposite edge. By describing everything with normalized coordinates,
everything can be painted on the correct place on the page, without knowing the
actual page size (in pixels) from the beginning.

RegularAreaRect, NormalizedRect, and the normalized coordinate system at all
don’t store information about text orientation or page orientation. For page
orientation, they (theoretically) simply assume 0°.

Further reading:
The class documentation is in core/area.h. I’m currently working on the
documentation, see https://phabricator.kde.org/D21266

-- 
You are receiving this mail because:
You are the assignee for the bug.