D21195: [RFC] Create a Change Colors menu (with toolbar button)

[David Hurka]

davidhurka added a comment.


  In D21195#468008 <https://phabricator.kde.org/D21195#468008>, @ngraham wrote:
  
  > +1 for this. I think it makes sense. Trying it out, I like it a lot.
  
  
  Sure?
  
  This isn’t even consistent with the Selection Tools button. They use an Okular::ToolButton, with delayed popup. (I don’t like this delay, don’t know the intention. Usually I replace the toolbar buttons with more useful ones, so I totally forgot about this button.) Should CheckableActionMenu be consistent with ToolButton and use delayed popup?
  
  Probably the approach of the Selection Tools button is cleaner, it separates menubar submenu and toolbar button, by adding the toolbar button as independent action to the KActionCollection. That would make CheckableActionMenu superfluous, KActionMenu would just work.
  
  I’ll make a TODO in the description.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21195

To: davidhurka, #okular, #vdg
Cc: GB_2, davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190521/8be9f64c/attachment.html>