D20832: Fix some clazy warning

Albert Astals Cid noreply at phabricator.kde.org
Tue May 21 21:36:16 BST 2019


aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Please revert the QStringLiteral with utf8 inside, after that you can commit if you're convince there will be no regressions :)

INLINE COMMENTS

> parttest.cpp:258
> +    QTest::newRow("non-utf8") << QStringLiteral("synctextest");
> +    QTest::newRow("utf8")     << QStringLiteral("ßðđđŋßðđŋ");
>  }

QStringliteral is broken on windows with non ascii chars, please turn this back to QString::fromUtf8 so tests don't start failing.

REPOSITORY
  R223 Okular

BRANCH
  fix_some_clazy_warning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20832

To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190521/c07a59b2/attachment.html>


More information about the Okular-devel mailing list