D21248: Add line annotation ending arrows for non PDF documents

Oliver Sander noreply at phabricator.kde.org
Tue May 21 09:25:43 BST 2019


sander added inline comments.

INLINE COMMENTS

> pagepainter.cpp:450
>                  // draw LineAnnotation MISSING: all
>                  if ( type == Okular::Annotation::ALine )
>                  {

Is  that `MISSING` comment still relevant?  What exactly does it mean anyway?

> pagepainter.h:83
> +            RasterOperation op
> +            );
> +

Nitpick: The identation of that `);` doesn't match the rest of the file.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21248

To: tobiasdeiminger
Cc: sander, knambiar, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190521/d6cd2d9b/attachment.html>


More information about the Okular-devel mailing list